Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort overload methods in the Navigator #5797

Merged

Conversation

junichi11
Copy link
Member

@junichi11 junichi11 commented Apr 8, 2023

@junichi11 junichi11 added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Apr 8, 2023
@junichi11 junichi11 added this to the NB18 milestone Apr 8, 2023
@junichi11 junichi11 force-pushed the java-navigator-sort-overload-methods branch from 58c281f to 7567fdb Compare April 10, 2023 23:26
@junichi11
Copy link
Member Author

Applied the suggested change from @matthiasblaesing . Thank you for it!

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Thank you.

@junichi11
Copy link
Member Author

@matthiasblaesing Thank you for your review and your time. I'll merge this.

@junichi11 junichi11 merged commit a0b7c0d into apache:master Apr 11, 2023
@junichi11 junichi11 deleted the java-navigator-sort-overload-methods branch April 11, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants