Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Find Usages for __construct method #4382 #5766

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Fix Find Usages for __construct method #4382 #5766

merged 1 commit into from
Apr 4, 2023

Conversation

junichi11
Copy link
Member

@junichi11
Fix Find Usages for __construct method apache#4382
1abc169 
- apache#4382
- Also find the new instance creation for the alias
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Apr 3, 2023
@junichi11 junichi11 added this to the NB18 milestone Apr 3, 2023
@junichi11 junichi11 linked an issue Apr 3, 2023 that may be closed by this pull request
"Find usages" on a PHP class constructor does not find uses of alias classes #4382
Closed
@junichi11 junichi11 requested a review from tmysik April 3, 2023 23:45
tmysik
tmysik approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@tmysik tmysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tmysik tmysik merged commit fa050d4 into apache:master Apr 4, 2023
@junichi11 junichi11 deleted the php-gh-4382-find-usage-alias-of-constructor branch April 4, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmysik tmysik tmysik approved these changes

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB18
Development

Successfully merging this pull request may close these issues.

"Find usages" on a PHP class constructor does not find uses of alias classes
2 participants
@junichi11 @tmysik