Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apidoc master branch links fix #5755

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

ebarboni
Copy link
Contributor

phase 2 of the apidoc .

This is part of #4450.
using the following to have ant javadoc -Dmetabuild.branch=master -Dapidocfullcheck=true.

Normaly build is apidoc error clean for master build (no idea yet for limited "release")

link to github file instead former mercurial
@link may be changed to @code as some item are protected and not public.
Hope this is enough.

@ebarboni ebarboni requested a review from mbien March 31, 2023 19:07
@ebarboni ebarboni added the JavaDoc [ci] enable java/javadoc tests and build-javadoc target label Mar 31, 2023
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - this was a lot of work for you

@ebarboni ebarboni force-pushed the apidocsainitizephase2 branch from 433aa70 to b96dbbd Compare April 3, 2023 08:54
@mbien mbien added this to the NB18 milestone Apr 3, 2023
@ebarboni
Copy link
Contributor Author

ebarboni commented Apr 4, 2023

merging maybe it will need a final works on a release build. Master build has all the javadoc build this was easy.

@ebarboni ebarboni merged commit 6921b8a into apache:master Apr 4, 2023
@ebarboni
Copy link
Contributor Author

ebarboni commented Apr 4, 2023

the master build show some remaining error on jenkins because javadoc should be build with jdk 20 or 19 (the one that match what we support)
https://ci-builds.apache.org/job/Netbeans/job/netbeans-TLP/job/netbeans/job/master/lastCompletedBuild/testReport/org.netbeans.nbbuild/CheckLinks/testBrokenLinks/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaDoc [ci] enable java/javadoc tests and build-javadoc target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants