Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code completion for @mixin #4683 #5745

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Fix code completion for @mixin #4683 #5745

merged 1 commit into from
Mar 30, 2023

Conversation

junichi11
Copy link
Member

@junichi11
Fix code completion for @mixin apache#4683
296995c 
- apache#4683
- Also get mixin fields as inherited fields
- Fix CC for the following case: `$variable->field::STATIC_MEMBER;`
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Mar 30, 2023
@junichi11 junichi11 added this to the NB18 milestone Mar 30, 2023
@junichi11 junichi11 linked an issue Mar 30, 2023 that may be closed by this pull request
[PHP] No IDE hint for promoted properties with @mixin #4683
Closed
@junichi11 junichi11 requested a review from tmysik March 30, 2023 12:56
tmysik
tmysik approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@tmysik tmysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tmysik tmysik merged commit 31875d5 into apache:master Mar 30, 2023
@junichi11 junichi11 deleted the php-gh-4683-cc-for-mixin branch March 30, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmysik tmysik tmysik approved these changes

@lalo-mx lalo-mx lalo-mx left review comments

@lbownik lbownik lbownik left review comments

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB18
Development

Successfully merging this pull request may close these issues.

[PHP] No IDE hint for promoted properties with @mixin
4 participants
@junichi11 @tmysik @lalo-mx @lbownik