apidoc error/warning fix (#6) #5734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebarboni
added
the
JavaDoc
ebarboni
commented
Mar 28, 2023
| @@ -70,7 +70,6 @@ | |||
| import javax.swing.text.html.HTML; | |||
| import javax.swing.text.html.HTMLEditorKit; | |||
| import javax.swing.text.html.parser.ParserDelegator; | |||
| import org.netbeans.api.*; | |||
| import org.netbeans.api.annotations.common.CheckForNull; | |||
There was a problem hiding this comment.
this removal seems mandatory to get javadoc
There was a problem hiding this comment.
always good to avoid star imports
ebarboni
commented
Mar 28, 2023
| @@ -72,7 +71,6 @@ public abstract class ScopeProvider { | |||
| * | |||
| * @see ScopeProvider#initialize(org.openide.util.Lookup, | |||
| * java.util.concurrent.atomic.AtomicBoolean) | |||
| * @see ScopeDescription | |||
| * @return an icon for the Scope, or null if the default should be used. | |||
There was a problem hiding this comment.
this class was never implemented.
was intended first https://bz.apache.org/netbeans/show_bug.cgi?id=217347#a0 (see attachement).
https://github.com/apache/netbeans/blob/master/ide/refactoring.api/src/org/netbeans/modules/refactoring/spi/impl/ScopeAnnotationProcessor.java could be fixed to remove the SupportedAnnotationTypes ScopeDescription
mbien
approved these changes
Mar 28, 2023
|
master is green merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sixth split of the big PR #4450.
using the following to have ant javadoc -Dmetabuild.branch=master -Dapidocfullcheck=true.
About 3/4 of the module pass.
I did a comment on a code modification that is removal of import. I don't know why it fails with this import. Many classes have unused import and no issue.
As part of the refactoring.api fixes it seems that annotationprocessor is supporting a never implemented type. (see inline comment)