Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use wait node in VSCode for long running computation of children" #5733

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Revert "Use wait node in VSCode for long running computation of children" #5733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/TreeViewProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,9 @@ public final CompletionStage<int[]> getChildren(int id) {

public final CompletionStage<Node[]> getChildren(Node nodeOrNull) {
Node node = getNodeOrRoot(nodeOrNull);
return CompletableFuture.completedFuture(node.getChildren().getNodes());
return CompletableFuture.supplyAsync(() -> {
return node.getChildren().getNodes(true);
}, INITIALIZE);
}

public final CompletionStage<Node> getParent(Node node) {
Expand Down
4 changes: 0 additions & 4 deletions java/java.lsp.server/vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,10 +1012,6 @@
"uriExpression": "nbres:/org/netbeans/modules/db/resources/view.gif",
"codeicon": "open-preview"
},
{
"uriExpression": "nbres:/org/openide/nodes/wait.gif",
"codeicon": "watch"
},
{
"uriExpression": "nbres:/org/netbeans/modules/cloud/oracle/resources/yellow_dot.svg",
"codeicon": "circle-large-outline",
Expand Down