Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the highlighting for private constants of Enum #5720

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Fix the highlighting for private constants of Enum #5720

merged 1 commit into from
Mar 26, 2023

Conversation

junichi11
Copy link
Member

Before:

nb-php-enum-private-constants-before

After:

nb-php-enum-private-constants-after

@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Mar 26, 2023
@junichi11 junichi11 added this to the NB18 milestone Mar 26, 2023
@junichi11 junichi11 requested a review from tmysik March 26, 2023 04:14
tmysik
tmysik approved these changes Mar 26, 2023
View reviewed changes
Copy link
Member

@tmysik tmysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@junichi11 junichi11 force-pushed the php-enum-private-const-highlighting branch from e5cb7df to 1dda0b0 Compare March 26, 2023 05:47
@tmysik tmysik merged commit fdbf8b4 into apache:master Mar 26, 2023
@junichi11 junichi11 deleted the php-enum-private-const-highlighting branch March 26, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmysik tmysik tmysik approved these changes

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB18
Development

Successfully merging this pull request may close these issues.
2 participants
@junichi11 @tmysik