Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GotoDeclaration in Enum implementing interface #5706

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

junichi11
Copy link
Member

Example

<?php
namespace Enum1;

interface ExampleInterface1 {}
interface ExampleInterface2 {}

namespace Enum2;

use Enum1\ExampleInterface1;
use Enum1\ExampleInterface2;

enum EnumImpl1 implements ExampleInterface1 {
    case A = 'A';
    case B = 'B';
}

enum EnumImpl2 implements ExampleInterface1, ExampleInterface2 {
    case A = 'A';
    case B = 'B';
}

Before:

nb-php-incorrect-goto-in-enum-before

After:

nb-php-incorrect-goto-in-enum-after

@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Mar 24, 2023
@junichi11 junichi11 added this to the NB18 milestone Mar 24, 2023
@junichi11 junichi11 force-pushed the php-incorrect-goto-in-enum branch from ae956f5 to fc35c51 Compare March 24, 2023 06:31
@junichi11 junichi11 changed the title Fix incorrect GotoDeclaration in Enum implementing interface Fix GotoDeclaration in Enum implementing interface Mar 24, 2023
@junichi11 junichi11 requested a review from tmysik March 24, 2023 22:07
@junichi11
Copy link
Member Author

@tmysik Could you please have a look at this? If there is no problem, let's merge it. Thank you!

@tmysik
Copy link
Member

tmysik commented Mar 25, 2023

Thanks for the tests.

@tmysik tmysik merged commit 1105e1f into apache:master Mar 25, 2023
@junichi11 junichi11 deleted the php-incorrect-goto-in-enum branch March 25, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants