Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1: Explicit octal integer literal notation #5026 #5695

Conversation

junichi11
Copy link
Member

@junichi11 junichi11 commented Mar 22, 2023

PHP 8.1:

nb-php81-explicit-octal-integer-literal-notation

PHP 8.0:

nb-php81-explicit-octal-integer-literal-notation-with-php80

- apache#5026
- https://wiki.php.net/rfc/explicit_octal_notation
- Fix lexers
- Fix `PHP81UnhandledError`
- Add unit tests for the parser and the lexer
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Mar 22, 2023
@junichi11 junichi11 added this to the NB18 milestone Mar 22, 2023
@junichi11 junichi11 requested a review from tmysik March 22, 2023 23:12
@junichi11
Copy link
Member Author

@tmysik Could you please have a look at this? If there is no problem, let's merge it. Thank you!

@tmysik tmysik merged commit 3093ce4 into apache:master Mar 23, 2023
@junichi11 junichi11 deleted the php-gh-5026-php81-explicit-octal-integer-literal-notation branch March 23, 2023 05:31
@junichi11 junichi11 linked an issue Mar 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PHP] Error for octal numbers with prefix in php8.1
2 participants