[maven hints] try to infer compiler plugin version from active maven version. #5693
Conversation
|
Nice idea. I think though, that I spotted a problem: Consider the situation where a new enough maven is present, but the compiler plugin is configured to an older version (for example because the project has $years of history). If I understand correctly, this might not be reported as an error. |
@matthiasblaesing agreed, we have to be especially careful with "false warnings". Its just that while testing #5679 I noticed that some hints won't appear at all since the embedded version of NB would be very recent, other hints will try to add the compiler plugin despite it already being there with the required version. Most of the maven editor support features only work properly right now if you leave the setting at "Bundled" and don't use a wrapper. This is a larger problem overall. |
mbien
force-pushed
the
fix-maven-compiler-plugin-checks
branch
from
24f1fad to
b71f24a
Compare
The plugin version query returns the version of the embedded maven distribution and not the verison of the active distribution. This worked fine until maven updated the versions of their implicitly provided lifecycle plugins (which is a good thing), then it broke. We can workaround this problem by comparing maven versions, since we can infer the plugin version from it under certain conditions. Fixes the release option and the module-info hint.
mbien
force-pushed
the
fix-maven-compiler-plugin-checks
branch
from
b71f24a to
71172ed
Compare
|
i made small changes to the comments to make them less confusing. Planning to merge once green again, thanks for review. |
mbien
changed the title
The plugin version query returns the version of the embedded maven distribution instead of the active distribution. This started causing issues the moment #5679 was implemented which upgrades embedded maven to a version which provides a JDK 9+ compatible plugins out of the box (which is a good thing).
We can workaround this problem by comparing maven versions, since we can infer the plugin version from it under certain conditions.
Fixes the release option and the module-info hint.