Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the code completion for instance context of Enum #5100 #5686

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

junichi11
Copy link
Member

- apache#5100
- Add cc items to `$this->`
- Add special keywords(`$this->`, `static::` etc.) inside Enum
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Mar 20, 2023
@junichi11 junichi11 added this to the NB18 milestone Mar 20, 2023
@junichi11 junichi11 linked an issue Mar 20, 2023 that may be closed by this pull request
@junichi11 junichi11 requested a review from tmysik March 21, 2023 00:51
@junichi11
Copy link
Member Author

@tmysik Could you please have a look at this? If there is no problem, let's merge it. Thanks!

Copy link
Member

@tmysik tmysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@tmysik tmysik merged commit 296dc8c into apache:master Mar 21, 2023
@junichi11 junichi11 deleted the php-gh-5100-cc-enum-this branch March 21, 2023 23:24
@junichi11
Copy link
Member Author

@tmysik Thank you for your reviews and your time!

@tmysik
Copy link
Member

tmysik commented Mar 22, 2023

@junichi11 Nothing to thank for, really. It is always a pleasure to cooperate with you. 👍

jlahoda pushed a commit to jlahoda/netbeans that referenced this pull request Apr 16, 2023
Fix the code completion for instance context of Enum apache#5100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PHP] Enum is missing autocompletion for instance context
2 participants