Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apidoc error/warning fix (#4) #5672

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

ebarboni
Copy link
Contributor

This is a forth split of the big PR #4450.
using the following to have ant javadoc -Dmetabuild.branch=master -Dapidocfullcheck=true.

JDK 19 to build so far is ok. about 1/3 (50) of the module pass. I change the rules to detect more missing link.

this is still phase 1 😄

@ebarboni ebarboni added the JavaDoc [ci] enable java/javadoc tests and build-javadoc target label Mar 17, 2023
@ebarboni ebarboni requested a review from mbien March 17, 2023 16:19
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I think I found a typo.

<arg value="-Xdoclint:html,reference,syntax" />
<arg value="-Xdoclint:all,-missing" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split on 2 args as it more the way to do that

@mbien mbien added this to the NB18 milestone Mar 18, 2023
@ebarboni ebarboni force-pushed the apidocsanitize4 branch 2 times, most recently from 53a5597 to 3d6488f Compare March 20, 2023 14:46
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still looks good to me :)

@ebarboni ebarboni merged commit 26cb521 into apache:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaDoc [ci] enable java/javadoc tests and build-javadoc target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants