Fix incorrect unused coloring #5551 #5670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmysik Could you please have a look at this? If there is no problem, let's merge it. Thanks! |
tmysik
reviewed
Mar 17, 2023
php/php.editor/src/org/netbeans/modules/php/editor/csl/SemanticAnalysis.java
Outdated
Show resolved
Hide resolved
tmysik
reviewed
Mar 17, 2023
php/php.editor/src/org/netbeans/modules/php/editor/csl/SemanticAnalysis.java
Outdated
Show resolved
Hide resolved
tmysik
approved these changes
Mar 17, 2023
|
@junichi11 Please, see my comment about the list implementation (I am OK with the current one), let me know. Then, I will merge it. Thanks! |
junichi11
force-pushed
the
php-gh-5551-incorrect-unused
branch
from
5d3d419 to
297f445
Compare
When there is an anonymous class in a method body, the anonymous class also removes method blocks of the enclosing class that need to be scanned. So, to prevent that, use `Map<TypeInfo, List<Block>>` instead of `List<Block>`
junichi11
force-pushed
the
php-gh-5551-incorrect-unused
branch
from
297f445 to
3cc64b4
Compare
|
CI: Some checks were not successful I canceled jobs once because the CI status was not shown. I re-ran all jobs again. |
|
@junichi11 looks good to me, PHP is green, everything else too. Only the cleanup job doesn't want to cleanup - all good. |
|
@mbien Thank you! |
|
@tmysik Thank you, Tomas!! |
|
@junichi11 You are welcome, of course! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is an anonymous class in a method body, the anonymous class also removes method blocks of the enclosing class that need to be scanned. So, to prevent that, use
Map<TypeInfo, List<Block>>instead ofList<Block>Before:
After: