Remove unnessary build options from project definitions #5652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the last remaining "-Xmx" overrides from the project.properties. The option does not seem to be used and the property definition overrides a previous one. In addition the "build.compiler=extJavac" option is removed as the build run correctly without this.
lkishalmi
approved these changes
Mar 11, 2023
|
Local runs were ok, github actions is green, the possibly affected unittests are run as part of the github actions and the other options affect the build, which is also done in the github actions. Lets get this in. Thank you for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the last remaining "-Xmx" overrides from the project.properties. The option does not seem to be used and the property definition overrides a previous one.
In addition the "build.compiler=extJavac" option is removed as the build run correctly without this.