Save/restore the ANTLR RustLexer specific internals. #5624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second commit is kind of optional, though I thought it is not good to store the whole token as that has attached fields, like the input CharStream, etc. that is better not to pass around. It seems the |
vieiro
approved these changes
Mar 8, 2023
pepness
pushed a commit
to pepness/incubator-netbeans
that referenced
this pull request
Mar 17, 2023
* Save/restore the ANTLR RustLexer specific internals. * Use just the token type in RustLexerBase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vieiro You might this one. I have not tested this trough, it just compiles.
The NB lexer saves/restores the lexer input at some wierd positions, and if the ANTLR lexer state is not fully saved/restored it can cause wide range of issues.