Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GlassFish 7.0.2 #5611

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Add support for GlassFish 7.0.2 #5611

merged 4 commits into from
Mar 8, 2023

Conversation

pepness
Copy link
Member

@pepness pepness commented Mar 5, 2023

Library Notes:

  • This is mainly a maintenance release that contains bug fixes and updates of various components.

NetBeans Testing:

  • Verify successful execution of libraries and licenses Ant test
  • Verify successful execution of Verify Sigtests
  • Verify successful execution of unit tests for modules glassfish.common, glassfish.javaee, glassfish.tooloing, glassfish.eecommon and j2ee.sun.dd
  • Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS
  • Successfully register GlassFish 7.0.2, create a web app and verify that it works.

Release Notes

@pepness pepness added Java EE/Jakarta EE [ci] enable enterprise job enterprise [ci] enable enterprise job labels Mar 5, 2023
@pepness pepness added this to the NB18 milestone Mar 5, 2023
@pepness pepness self-assigned this Mar 5, 2023
mbien
mbien approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. looks good!

@mbien
Copy link
Member

mbien commented Mar 7, 2023

btw: the tests you updated are actually not hooked into CI. If you think they are important, feel free to add them to the enterprise job.
https://github.com/apache/netbeans/blob/master/.github/workflows/main.yml#L1884
(same for your JPA PR for course)

@pepness pepness merged commit 94ad31f into apache:master Mar 8, 2023
pepness added a commit to pepness/incubator-netbeans that referenced this pull request Mar 17, 2023
@pepness
Add support for GlassFish 7.0.2 (apache#5611)
c021c12 
- Add missing config file
- Fix wrong ServerDetails version for GlassFish 7.0.1
- Add missing validation for GlassFish version 7
- Add more tests and fix some others
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

Assignees

@pepness pepness

Labels
enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job
Projects
None yet
Milestone
NB18
Development

Successfully merging this pull request may close these issues.
2 participants
@pepness @mbien