Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate PHP signature files #5565

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

junichi11
Copy link
Member

PHP Documentation: Date: 21 Feb 2023

I've verified that there is no exception when I open a PHP file.

@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Feb 26, 2023
@junichi11 junichi11 added this to the NB18 milestone Feb 26, 2023
PHP Documentation: Date: 21 Feb 2023
@junichi11 junichi11 force-pushed the regenerate-php-sigfiles-1.5 branch from b2a672b to be7cf3b Compare February 26, 2023 05:07
@apache apache locked and limited conversation to collaborators Feb 26, 2023
@apache apache unlocked this conversation Feb 26, 2023
@apache apache locked and limited conversation to collaborators Feb 26, 2023
@apache apache unlocked this conversation Feb 26, 2023
@junichi11 junichi11 requested a review from tmysik February 26, 2023 22:11
@tmysik
Copy link
Member

tmysik commented Feb 27, 2023

@junichi11 Junichi, just to be sure - we can merge this PR, right? If so, feel free to do so. Thanks.

@junichi11
Copy link
Member Author

@tmysik Yes, we can merge it :) Thanks!

@junichi11 junichi11 merged commit c097693 into apache:master Feb 27, 2023
@junichi11 junichi11 deleted the regenerate-php-sigfiles-1.5 branch February 27, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants