Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Glassfish 7.0.1 #5466

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Add support for Glassfish 7.0.1 #5466

merged 4 commits into from
Feb 13, 2023

Conversation

pepness
Copy link
Member

@pepness pepness commented Feb 10, 2023

  • Add missing validations for servlet 5 and 6
  • Add missing glassfish 4 objects in ASDDVersion class

NetBeans Testing:

  • Verify successful execution of libraries and licenses Ant test
  • Verify successful execution of Verify Sigtests
  • Verify successful execution of unit tests for modules glassfish.common, glassfish.javaee, glassfish.tooloing, glassfish.eecommon and j2ee.sun.dd
  • Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS
  • Successfully register GlassFish 7.0.1, create a web app and verify that it works.

@pepness pepness added Java EE/Jakarta EE [ci] enable enterprise job enterprise [ci] enable enterprise job labels Feb 10, 2023
@pepness pepness added this to the NB18 milestone Feb 10, 2023
@pepness pepness self-assigned this Feb 10, 2023
matthiasblaesing
matthiasblaesing approved these changes Feb 11, 2023
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me (not an expert here though), I saw an unclear comment that may need some more explanation.

matthiasblaesing
matthiasblaesing approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update

@pepness pepness merged commit e13155a into apache:master Feb 13, 2023
vieiro pushed a commit to vieiro/netbeans-cnd that referenced this pull request Mar 6, 2023
@pepness @vieiro
Add support for Glassfish 7.0.1 (apache#5466)
16d37cd 
- Add missing validations for servlet 5 and 6
- Add missing glassfish 4 objects in ASDDVersion class
- Remove ancient comment, there is already logic to support lookup keys
  and deployers for glassfish version 3 and upward
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees

@pepness pepness

Labels
enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job
Projects
None yet
Milestone
NB18
Development

Successfully merging this pull request may close these issues.
2 participants
@pepness @matthiasblaesing