-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS: Support recursive calc definition, improve compatibility for custom properties, support :has pseudo-class #5432
Merged
matthiasblaesing
merged 5 commits into
apache:master
from
matthiasblaesing:css_improvements
Feb 8, 2023
Merged
CSS: Support recursive calc definition, improve compatibility for custom properties, support :has pseudo-class #5432
matthiasblaesing
merged 5 commits into
apache:master
from
matthiasblaesing:css_improvements
Feb 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1486d3
to
b7394ab
Compare
vieiro
reviewed
Feb 5, 2023
vieiro
reviewed
Feb 5, 2023
ide/css.lib/src/org/netbeans/modules/css/lib/api/properties/Properties.java
Outdated
Show resolved
Hide resolved
vieiro
reviewed
Feb 5, 2023
ide/css.lib/src/org/netbeans/modules/css/lib/properties/GrammarParser.java
Outdated
Show resolved
Hide resolved
vieiro
reviewed
Feb 5, 2023
vieiro
approved these changes
Feb 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks, @matthiasblaesing
@vieiro thank you for the review. I pushed updates - could you have another look? |
@matthiasblaesing Great job. Thanks again for this! |
The grammar for calc property values failed to parse embedded var and calc calls correctly. The issue is the work-around introduces as function-content, which basicly prevents nesting any expression that contains braces. This changes the grammar parsing result from a tree to a directed graph, which can contain cycles. This needs to taken into account by useers of the parsed grammar. An example of such a cycle is: calc-fn -> calc-sum -> calc-product -> calc-value -> calc-sum ^ | +----------------------------------------+ Closes: apache#5025
ecd64ee
to
d4d8c15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:dev-build
[ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page)
CSS
[ci] enable web job
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support recursive CSS property definitions (calc function with embedded function calls)
The grammar for calc property values failed to parse embedded var and
calc calls correctly. The issue is the work-around introduces as
function-content, which basicly prevents nesting any expression that
contains braces.
This changes the grammar parsing result from a tree to a directed graph,
which can contain cycles. This needs to taken into account by useers of
the parsed grammar.
An example of such a cycle is:
For example this is now supported:
Improve compatibility for custom properties
Custom properties can hold more or less arbitrary content. This was not parsed and is now:
Support CSS :has pseudo-class
This was not parsed and is now:
Closes: #5025
Closes: #5303