Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed javadoc tags #5419

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Fixed javadoc tags #5419

merged 1 commit into from
Feb 3, 2023

Conversation

tbw777
Copy link
Contributor

@tbw777 tbw777 commented Feb 3, 2023 •
edited
Loading

A part of javadoc sync global superproject

I can fix every nb byte

@ebarboni ebarboni added Code cleanup JavaDoc [ci] enable java/javadoc tests and build-javadoc target labels Feb 3, 2023
@ebarboni
Copy link
Contributor

ebarboni commented Feb 3, 2023

hi @tbw777 would be nice if you can link the other PR about javadoc changes you made.
@mbien this save me some times :p on the split of #4450.

@tbw777
Copy link
Contributor Author

tbw777 commented Feb 3, 2023

This PR changes type is independent of other

@ebarboni
Copy link
Contributor

ebarboni commented Feb 3, 2023

sorry was thinking on other PR you made about javadoc fixes like #5222.

@tbw777
Fixed javadoc tags
c543b8d 
A part of javadoc sync global superproject
@tbw777 tbw777 requested a review from mbien February 3, 2023 19:51
pepness
pepness approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@pepness pepness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

mbien
mbien approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update. Looks good.

@mbien mbien merged commit 8d16de8 into apache:master Feb 3, 2023
@mbien mbien added this to the NB18 milestone Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

@pepness pepness pepness approved these changes

Assignees
No one assigned
Labels
Code cleanup JavaDoc [ci] enable java/javadoc tests and build-javadoc target
Projects
None yet
Milestone
NB18
Development

Successfully merging this pull request may close these issues.
4 participants
@tbw777 @ebarboni @mbien @pepness