Report progress start when handle immediately switches to indeterminate. #5362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
LSP
MartinBalin
approved these changes
Jan 25, 2023
Merged
dbalek
approved these changes
Jan 30, 2023
|
You still wanting to get #5361 into NB17? In which case, this should be too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing of #5361, I've found out that the
LspInternalHandlereceives SWITCH event as the first one (as a result of the switch to indeterminate status), and does not report start event to the LSP client at all. As a result the progress indicator is never created in LSP client and the progress for long-running operation may remain unreported.sendProgresswill first sendstartevent to the client, if not already started.