Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.2 Support: Constants in Traits and Disjunctive Normal Form Types #5302

Merged
merged 7 commits into from
Jan 17, 2023
Merged

PHP 8.2 Support: Constants in Traits and Disjunctive Normal Form Types #5302

merged 7 commits into from
Jan 17, 2023

Conversation

junichi11
Copy link
Member

PHP 8.2 Support: Constants in Traits (Part 1)

PHP 8.2
nb-php82-constants-in-traits-syntax

PHP 8.1
nb-php82-constants-in-traits-syntax-php81

PHP 8.2 Support: Constants in Traits (Part 2)

PHP 8.2 Support: Constants in Traits (Part 3)

PHP 8.2 Support: Constants in Traits (Part 4)

PHP 8.2 Support: Constants in Traits (Part 5)

PHP 8.2 Support: Disjunctive Normal Form Types (Part 1)

PHP 8.2
nb-php82-dnf-types-syntax

PHP 8.1
nb-php82-dnf-types-syntax-php81

@junichi11
PHP 8.2 Support: Constants in Traits (Part 1)
7254745 
- apache#4725
- https://wiki.php.net/rfc/constants_in_traits
- Fix the grammar file
- Fix `PHP82UnhandledError`
- Add/Fix unit tests for the parser, the lexer, and `IncorrectEnumHintError`
@junichi11
PHP 8.2 Support: Constants in Traits (Part 2)
1850b45 
- apache#4725
- https://wiki.php.net/rfc/constants_in_traits
- Add trait constants to the index
- Fix the navigator
- Add unit tests for the index and the navigator
@junichi11
PHP 8.2 Support: Constants in Traits (Part 3)
2da827c 
- apache#4725
- https://wiki.php.net/rfc/constants_in_traits
- Fix coloring for trait constants
- Add unit tests
@junichi11
PHP 8.2 Support: Constants in Traits (Part 4)
89850d7 
- apache#4725
- https://wiki.php.net/rfc/constants_in_traits
- Fix the code completion feature
- Add unit tests
@junichi11
PHP 8.2 Support: Constants in Traits (Part 5)
f66f20f 
- apache#4725
- https://wiki.php.net/rfc/constants_in_traits
- Fix the mark occurrences and the go to declaration
- Add unit tests
@junichi11
PHP 8.2 Support: Disjunctive Normal Form Types (Part 1)
76ffef8 
- apache#4725
- https://wiki.php.net/rfc/dnf_types
- Fix the grammar file, `PHP82UnhandledError`, and `UnusableTypeHintError`
- Add/Fix unit tests for the parser
@junichi11
Fix the release date of PHP 8.2
73a3549
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Jan 16, 2023
@junichi11 junichi11 added this to the NB17 milestone Jan 16, 2023
@junichi11 junichi11 mentioned this pull request Jan 16, 2023
Closed
6 tasks
@junichi11 junichi11 requested a review from tmysik January 17, 2023 02:27
@junichi11
Copy link
Member Author

@tmysik Could you please have a look at this if you have time today?
After that, let's merge #5300.

I thought we can merge PR for NB17 until tomorrow, but it is until today.
I'm so sorry to rush you...
If you are busy, let's merge #5300 without merging this :) (I'll change to NB18)

@tmysik tmysik merged commit 4e0486e into apache:php82-support Jan 17, 2023
@junichi11
Copy link
Member Author

Thank a lot for your review and your time!

@junichi11 junichi11 deleted the php82-constants-in-traits branch January 17, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmysik tmysik tmysik approved these changes

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB17
Development

Successfully merging this pull request may close these issues.
2 participants
@junichi11 @tmysik