ci: add retry script to ide/options.editor tests and increase mac timeout. #5254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
requested review from
lkishalmi,
matthiasblaesing,
neilcsmith-net,
entlicher and
sdedic
matthiasblaesing
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checked the CI runs of the last 18 merges to master to see if we can reduce the whack-a-mole factor a bit.
Most had
java.mx.projectfailing which is already wrapped in a retry script andcontinue-on-erroris set to true for merges. I couldn't reproduce the failure locally, it always passed, so this one might be tricky to fix (previews attempt #4100).But
ide/options.editordid also fail often. Those are fairly short tests which could benefit from a retry script - which I added with this PR.I did also increase the job timeout on mac since the mac runners can sometimes have really high latencies or artifact download speeds.
The other tests failing were in
java/refactoring.javaandjava.source.basewhich would be mitigated by #5138 if it makes it in before freeze.