-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded Gradle Tooling API to 8.0-rc-1 #5240
Upgraded Gradle Tooling API to 8.0-rc-1 #5240
Conversation
@sdedic I need your help with this one. A bunch of test cases are failing. I guess some could be easily fixed if the gradle version would be set on test execution. for that it would be sufficuent to create an appropriate gradle-wrapper.properties on the test projects. |
Gradle 8.0-rc1 release notes for the curious |
Forced a couple of test project to use Gradle 7.5 for building. It seems The Gradle tests are running well on Java 11. |
And now it's green! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. A quick hello world test worked too (JDK 19).
I think we should merge this before freeze to get some testing in and update to the GA version during RC which would be a smaller PR.
ExecutionOptionsPanel.cbNoRebuild.text=Do not Rebuild Project Dependencies | ||
ExecutionOptionsPanel.cbNoRebuild.text=<html><strike>Do not Rebuild Project Dependencies</strike> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deprecated checkbox - I love it :D
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to mention that I think this is fine to downgrade specific modules.
But we should not forget about this, since they could stay behind and cause problems later. Ideally we should try to keep the versions in sync or close together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we shall keep that in our mind.
Telling the truth, these test are on the border line of unit/integration, as they are using third-party plugins. Those plugins are not necessary support the current Gradle release.
* Upgraded Gradle Tooling API to 8.0-rc-1 * Fixed jar task property removal in Gradle 8.0 * Deprecate no-rebuild Gradle option. * Use Gradle 7.5 for micronaut tests * Set Gradle 7.5 for some sensitive test projects * Use Gradle 7.5 for Micronaut tests
Well, I hope by the time of our release Gradle 8.0 will be available. In order to prepare for that this PR is to update of Gradle's Tooling API.
Later on when Gradle 8.0 will be available, I'll provide a PR for that one as well.