Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoload default config profiles into ServerInstances. #5226

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Jan 6, 2023

The recent commit #5118 introduced the ability to select and add OCI profiles, but damaged the Cloud Explorer for Apache Netbeans VSCode extension - it relied on the (default) OCI profile to be automatically converted into ServerInstance.

This PR adds an alternative mode, which can be enabled using Branding API, that automatically loads all profiles from the default OCI configuration into the Cloud explorer (in NB IDE or vscode). In the future additional profiles from custom configuration can be added when the Add Cloud / Oracle wizard is enhanced to support custom configs.

NetBeans IDE behaves as in #5118, for the user convenience, vscode extension loads profiles from the default config.

@sdedic sdedic added kind:bug Bug report or fix LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests enterprise [ci] enable enterprise job labels Jan 6, 2023
@sdedic sdedic added this to the NB17 milestone Jan 6, 2023
@sdedic sdedic requested review from jhorvath and MartinBalin January 6, 2023 15:32
@sdedic sdedic self-assigned this Jan 6, 2023
@sdedic sdedic requested a review from dbalek January 9, 2023 08:51
@sdedic sdedic merged commit 0401cc1 into apache:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enterprise [ci] enable enterprise job kind:bug Bug report or fix LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants