Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NETBEANS-1309] add support for @summary javadoc tag #5180

Merged
merged 1 commit into from
Jan 5, 2023
Merged

[NETBEANS-1309] add support for @summary javadoc tag #5180

merged 1 commit into from
Jan 5, 2023

Conversation

jherkel
Copy link
Contributor

@jherkel jherkel commented Jan 2, 2023

@mbien mbien added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) JavaDoc [ci] enable java/javadoc tests and build-javadoc target labels Jan 2, 2023
@apache apache locked and limited conversation to collaborators Jan 2, 2023
@apache apache unlocked this conversation Jan 2, 2023
@mbien mbien added this to the NB17 milestone Jan 2, 2023
@mbien
Copy link
Member

mbien commented Jan 5, 2023

NetBeans 16 already has auto completion for the summary tag. What is this PR adding to that?

@jherkel
Copy link
Contributor Author

jherkel commented Jan 5, 2023

@mbien With this patch you can see content of "@summary" tag when javadoc popup is displayed and also reformatting of "@summary" tag should be working.

@matthiasblaesing
Copy link
Contributor

@mbien I think this comparison shows the fix. Compare the contents of the javaodoc comment and the rendering.

Before:

image

After:

image

matthiasblaesing
matthiasblaesing approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks sane to me.

mbien
mbien approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome - code looks good. Thanks a lot for the screenshots, I was testing it but must have overlooked that detail.

Screenshots are great in general since PRs are directly linked from the release notes.

@mbien
Copy link
Member

mbien commented Jan 5, 2023

merging since we just fixed master :)
thanks @jherkel!

@mbien mbien merged commit b7ba5d6 into apache:master Jan 5, 2023
This was referenced Feb 28, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

@jlahoda jlahoda Awaiting requested review from jlahoda

@singh-akhilesh singh-akhilesh Awaiting requested review from singh-akhilesh

Assignees
No one assigned
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) JavaDoc [ci] enable java/javadoc tests and build-javadoc target
Projects
None yet
Milestone
NB17
Development

Successfully merging this pull request may close these issues.
3 participants
@jherkel @mbien @matthiasblaesing