Gradle Execution Customizer with Runtime #5158

lkishalmi · 2022-12-29T08:12:54Z

This one is about evolving the Java Runtime selection further, beyond the recent patches, that made it possible in NB16u1.

The old implementation was mimicking what Maven/Ant does at the Build/Compile customizer. Those days the runtime platform pretty much determined the compile platform as well. The introduction of JVM Toolchains made that different.

Nowadays it is enough to have the JRE installed to start a Gradle build, Gradle can download and use different JVM-s if needed.

I also made the Java Runtime selection available on root project only, sub-projects would take the root project setting.

That's why the GradleJavaRuntimeManager and JavaRuntime got introduced as an API. Feedbacks on that are welcome, I think it's good enough, but could be improved to be more future proof.

I've implemented this as a series of commits, so reviewing might be easier that way. JavaDoc and API doc would be provided later and in this PR.

Eventually I would like to deprecate all the methods in JavaRunUtils, but they are used in the BootClasspath support at the moment. The bootclasspath support is not JVM Toolchain aware now, so that needs to be addressed, though I thought that would be a separate PR.

Changed to

While the Build/Compile customizer got removed.

extide/gradle/src/org/netbeans/modules/gradle/spi/execute/JavaRuntimeManager.java

java/gradle.java/src/org/netbeans/modules/gradle/java/JavaRuntimeManagerImpl.java

extide/gradle/src/org/netbeans/modules/gradle/GradleBrokenRuntimeProblemProvider.java

extide/gradle/src/org/netbeans/modules/gradle/customizer/Bundle.properties

sdedic · 2023-01-10T08:38:19Z

extide/gradle/src/org/netbeans/modules/gradle/spi/execute/JavaRuntimeManager.java

+ *
+ * @author Laszlo Kishalmi
+ */
+public interface JavaRuntimeManager {


If intending to merge before NB17 branching, javadocs + apichanges should be added for this + other API changes. Maybe some overview javadoc that explains purpose / difference between JavaPlatform and JavaRuntime.

extide/gradle/src/org/netbeans/modules/gradle/spi/execute/JavaRuntimeManager.java

mbien · 2023-01-14T10:01:19Z

So this moves the item in build -> compile to build -> gradle execution. This seems to have the side effect that something which was configurable on a per-sup-project basis is now only configurable in the root project?

UI wise i would consider swapping the Java Runtime panel with Trust Level panel.

lkishalmi · 2023-01-14T16:34:15Z

@mbien Yes, we are going to loose the per sub-project level of the Java Runtime Setting. I think that's a happy loss.
I'm switching the panels...

lkishalmi · 2023-01-14T20:57:26Z

mbien · 2023-01-15T11:38:03Z

looks good to me. Layout is also working. The setting is also successfully changing the runtime JDK of the project.

The "release" version (javac --release) can't be changed via the gradle UI?

I don't see "Compile" options in the UI btw which is on the last screenshot you posted.

The options window likely needs a scrollpane for the sub options since some don't fit the window (e.g Formatting options) - but this is also the case for maven project and out of the scope of this PR.

lkishalmi · 2023-01-15T16:35:56Z

I've posted the screenshot with only the Gradle Project recompiled, so the Gradle Java Projects were on master, so that provided the Compile Customizer.

The Gradle UI is kind of read-only. Yes, the runtime setting can affect the java release/platform used in projects. Though that is a bad practice. That means that the Gradle build files does not set that by any other means. It's possible to set the Java release version per source set. Since the introduction of Java Toolchains, the actual platform in use can be specified even on task level.

It's getting close to the freeze. Any approver?

mbien

since you are asked so nicely I approve.

But I ran only rudimentary tests today. Code looks good to me.

mbien · 2023-01-15T17:11:34Z

extide/gradle/src/org/netbeans/modules/gradle/spi/execute/JavaRuntimeManager.java

+        final String displayName;
+        final File javaHome;
+
+        private JavaRuntime(@NonNull String id, String displayName, File javaHome) {


this looks like it could use Path?

* Moved Gradle Java Runtime Selection into Gradle Projects * GradleJavaPlatformProviderImpl uses the JavaRuntimeManager now. * Moved GradleJavaProjectProblemProvider to Gradle Project * Added change aware bridge between JavaRuntime and JavaPlatform * Removed unloadable project warning from customizer, other fixes * Polishing the code according suggestions. * Adjusted Bundle.properties for the customizers. * Added API documentation. * Mage JavaRuntime on top of Gradle Execution Customizer

lkishalmi added the Gradle [ci] enable "build tools" tests label Dec 29, 2022

lkishalmi added this to the NB17 milestone Dec 29, 2022

lkishalmi requested review from mbien, jtulach, matthiasblaesing, neilcsmith-net and sdedic December 29, 2022 08:12