-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Javadoc 17 parsing #5127
Fix Javadoc 17 parsing #5127
Conversation
java/java.sourceui/test/unit/src/org/netbeans/api/java/source/ui/HTMLJavadocParserTest.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
f187879
to
6b70931
Compare
Thanks @mbien Yes, aware the tests were disabled. Have added an extra commit to enable with two exclusions. FastIndexTest is failing to access JDK sources. MarkupTagProcessorTest doesn't seem like it ever could have worked - failing equality test on a class that doesn't implement equals(). 🤷 |
this PR triggered a bug in CI. If a job times out it counts as cancelled, which makes it think that the user cancelled the workflow and the cleanup job will run which means that we can't restart the timed out job since the workspace artifact is already gone. Sorry about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I did not totally follow the changes in JavadocHelper, but the new tests look sane and I verified, that the problem exists and is fixed by this change. Thank you.
Thanks for the reviews - merging.
Yes, at some point we could probably do with not parsing HTML5 with an HTML 3.2 parser! 😄 |
That would be great. The current HTMLJavadocParser.parseMember method doesn't work for a lot of methods of OpenJDK 21 that don't have “a” tags in their sections. I can't follow the quirks of the current state machine (eg. hrpos and A_OPEN/A_CLOSE), so I can't produce a reliable patch./PR Should I open an issue about it? Thanks. |
Attempt to fix parsing of Javadoc HTML generated by Java 17, which uses
<section>
tags, so that documentation shows up in code completion if no source available.Second commit fixes external link format when linking to a constructor or method with multiple parameters.