-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test bugfixes: preparation for GH action migration #4975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Appreciate the fixes to the exception logging too - this makes it easier to find issues in the log when something happens.
<condition property="test.bootclasspath.prepend.args" value="--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming,jdk.jdi"> | ||
<condition property="test.bootclasspath.prepend.args" value="--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming,jdk.jdi,jdk.unsupported"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent! This means we have another job which could run on JDK 11+ (e.g in a matrix).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really - there are still some failing tests, I asked @dbalek for an assistance as the failure seems to be deeply burried in javac binding infrastructure. But it's definitely a step forward.
lets merge this this week so that we can finish up the migration PR and open it for review. Travis will end free support for open source projects, apache projects have to migrate before the end of this year. |
A follow-up to #4921.
The most important fix is a fix to
nbjavac
task that prevents classes like$JsCallback$
and similar to be deleted just before an incremental compilation because they are considered inner classes (without a matching outer class).I've added additional logging to both server and client, because some thrown errors are wrapped into uninformative "Internal error". Added possibility to log-trace LSP messages (enabled by System property)
I've cleaned up the test a little:
sun.misc.Unsafe
during script engine initialization