-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent CCE NbGradleProjectImpl to DataObject #4943
Prevent CCE NbGradleProjectImpl to DataObject #4943
Conversation
gh might be having issues since I can't label this PR (or other PRs). Unfortunately this means the Gradle tests won't run. nevermind. was a temporary issue. Restarted the build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense + looks like a fairly low risk change
Oh, I knew I forgot something! I'm sorry. |
Yes,there's even an editor API for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that all occurrences are replaced.
@@ -60,6 +60,7 @@ | |||
*/ | |||
public final class GradleCommandLine implements Serializable { | |||
|
|||
private static final String GRADLE_PROJECT_PROPERTY = "gradle-project"; //NOI18N |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover ?
But maybe declare the property as public
somewhere to have a shared constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of. Did not want to change the API so late in NB16 cycle, so marked that private and made the two now public non API one with a comment. Will pick that up for NB17
Great, thanks @lkishalmi . I've seen that exception a couple of times recently testing 16, but could never reproduce what triggered it. Should have opened an issue with it though. |
Playing with Ernies composite build in #4865 I've encountered the following exception
It seems some other NetBeans parts expecting a
DataObject
in a DocumentDocument.StreamDescriptionProperty
as Stream descriptor. I used that property ages ago probably seen that on some other editor. This PR just change the property name used for the code completion provider.It seems if this exception does not happen, then the registration of the JDPA listener would g through, fixing #4865 entirely.