support running tests from non default test folders

[Honza-cz]

Netbeans are not able to run the test in extra test source folder added by build-helper-maven-plugin maven plugin ...

<plugin>
    <groupId>org.codehaus.mojo</groupId>
    <artifactId>build-helper-maven-plugin</artifactId>
    <version>1.9.1</version>
    <executions>
        <execution>
            <id>add-test-source</id>
            <phase>generate-test-sources</phase>
            <goals>
                <goal>add-test-source</goal>
            </goals>
            <configuration>
                <sources>
                    <source>src/it/java</source>
                </sources>
            </configuration>
        </execution>
    </executions>
</plugin>

If I run the test by Ctrl+F6, netbeans is not able to replace packageClassName by a test name

cd /.../repository; JAVA_HOME=/.../jdk-19.0.1 /.../netbeans/java/maven/bin/mvn -Dtest=${packageClassName} surefire:test

After fix:

cd /...repository; JAVA_HOME=/.../jdk-19.0.1 /.../netbeans/java/maven/bin/mvn -Dtest=some.pkg.Test surefire:test

The updated code is covered by UT.

This pull request is linked to my previous one which I decided to close due to wrong fix.

[Honza-cz]

@neilcsmith-net : You pointed a week ago how to fix that issue and in fact it simplifies the fix. Can you maybe have a look again?

[neilcsmith-net]

@Honza-cz thanks for the contribution. Kicked off tests and requested reviews. Some of us tied up with finalising NB16 release at the moment, so might take a little while.

[sdedic]

Please check whether syntax with comma-separated package names (not paths) works in ancient Surefire version - according to docs, there were some significant changes in Surefire 2.19. We recommend Surefire 2.22 for Junit5, and surefire 2.8 (which may fail with this syntax) for single test run. See org.netbeans.modules.maven.ActionProviderImp::checkSurefire for details.

[Honza-cz]

I made a test with junit:4.12 and maven-surefire-plugin:2.8. In Netbeans I selected 2 packages and execute them. It generated -Dtest=some.it.pkg.other.**,some.it.pkg.** and it run the tests in those packages as expected:

Running some.it.pkg.ItTest ... Running some.it.pkg.other.It3Test ...

Is a such manual test enough?

[Honza-cz]

let me know in case of any doubts. thx in advance. @sdedic , @neilcsmith-net

[Honza-cz]

@sdedic , @neilcsmith-net : any update?

This fix will help me in my day-to-day job to be able to run the tests by IDE directly and not by maven which is ok, but a bit unnecessary.

[Honza-cz]

@neilcsmith-net, @sdedic : Kind reminder
... I started to accept the reality that this update won't make it to official release

[sdedic]

Apologies - pings lost in the mail traffic. Looks good; thanks for the patience / persistence.

[mbien]

looks good to me too.

PR is reviewed and it looks like all questions were sufficiently answered. Tests are included which cover this change and everything is green.

@Honza-cz congrats to your first contribution -> merging

[mbien]

squashing locally + rebase force push. will merge when green on all tests - don't want to risk anything one day before freeze.