Fix mapping of dependencies described as key/value maps to the source #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
Gradle
MartinBalin
approved these changes
Nov 4, 2022
|
I will not add it to NB 16 at this moment as such syntax is rarely used. Can wait. |
dbalek
approved these changes
Nov 8, 2022
ppisl
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
DependencyResult.getDeclarationRangefailed to find a dependency that was specified using a map, e.g.parser was ok, but matching ignored such dependency text. Relevant tests for various dependency entry syntaxes were added.
Additional: a subtle bug in Oracle Cloud Vulnerability Audit feature was found that resulted in NPE in some cases, so a cached audit might not appear.
@MartinBalin might be also included in NB16, if it is not too late. Please decide, I'll eventually rebase.