Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JDK 19 Javadoc link from EA to GA. #4836

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

neilcsmith-net
Copy link
Member

Update JDK 19 Javadoc link from early access to the release location.

Quick fix in delivery as I noticed while testing 16-rc1 on JDK 19 that Javadoc linking is broken. However, might be good to consider a better way of handling this in future.

@neilcsmith-net neilcsmith-net added kind:bug Bug report or fix Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) labels Oct 21, 2022
@neilcsmith-net neilcsmith-net added this to the NB16 milestone Oct 21, 2022
@mbien
Copy link
Member

mbien commented Oct 21, 2022

oh nice, I wanted to update that but totally forgot. Was thinking to generate those links somehow. Take the date, do some math and calculate what the URL must be. JDK release schedule is super stable.

@neilcsmith-net
Copy link
Member Author

@mbien yes, that's similar to what I was thinking - mostly why I pinged you for review. 😄

@mbien
Copy link
Member

mbien commented Oct 21, 2022

i created #4837. Its set against delivery right now. Not sure what we want to get into NB 16. If we target it against NB 17 i will wait with merge until this PR here made it back to master.

@neilcsmith-net
Copy link
Member Author

I'd rather keep this for NB16, and target better changes for NB17. I'm also wondering whether the date approach is the right one, rather than prepopulating all the ones up to the supported source level in the IDE, and possibly pinging the docs site if a higher JDK is requested.

@neilcsmith-net neilcsmith-net merged commit a4f87a2 into apache:delivery Oct 24, 2022
@neilcsmith-net neilcsmith-net deleted the jdk19-doclink branch January 16, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) kind:bug Bug report or fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants