Testcases related fixes #44
Conversation
| @@ -50,7 +50,7 @@ protected void tearDown () throws Exception { | |||
| public void testCreate () throws Exception { | |||
| String name = "new-one"; | |||
| String displayName = "Newone"; | |||
| URL url = UpdateUnitFactoryTest.class.getResource ("data/catalog.xml"); | |||
| URL url = CatalogCacheTest.class.getResource ("data/catalog.xml"); | |||
There was a problem hiding this comment.
Why not use UpdateProviderFactoryCreateTest.class here? Or even getClass().getResource() ?
This reverts commit 3a220bf.
| @@ -50,7 +49,7 @@ protected void tearDown () throws Exception { | |||
| public void testCreate () throws Exception { | |||
| String name = "new-one"; | |||
| String displayName = "Newone"; | |||
| URL url = UpdateUnitFactoryTest.class.getResource ("data/catalog.xml"); | |||
| URL url = getClass().getResource ("/org/netbeans/modules/autoupdate/updateprovider/data/catalog.xml"); | |||
There was a problem hiding this comment.
Doesn't the relative path data/catalog.xml work anymore?
There was a problem hiding this comment.
There's no catalog.xml here : https://github.com/apache/incubator-netbeans/tree/master/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate
There was a problem hiding this comment.
no data/catalog.xml in above location
There was a problem hiding this comment.
There was a problem hiding this comment.
Can you please approve this?
There was a problem hiding this comment.
I didn't know you were waiting for me. Sure, it looks good!
|
What needs to be done to complete this one? |
|
Merged it. |
Removed failing test UpdateUnitFactoryTest. This test depends on the test .nbm files that were removed at the time of donation.
Fixed failing test UpdateProviderFactoryCreateTest.