Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-54] Module Review api.xml #36

Merged
merged 1 commit into from
Oct 7, 2017

Conversation

junichi11
Copy link
Member

  • no external library
  • checked Rat report: add the license header in two *.dtd. ignore three package-list[1] files, org-netbeans-api-xml.sig
  • A unit test fails even if the license header is not added. (ClassNotFoundException: org.apache.crimson.parser.XMLReaderImpl)

[1] http://docs.oracle.com/javase/8/docs/technotes/tools/windows/javadoc.html#JSWOR663

- no external library
- checked Rat report: add the license header in two *.dtd. ignore three package-list files, org-netbeans-api-xml.sig
- A unit test fails even if the license header is not added.
@junichi11 junichi11 force-pushed the module-review-api.xml branch from d94a8cb to ff5b77a Compare October 7, 2017 11:21
@asfgit asfgit merged commit ff5b77a into apache:master Oct 7, 2017
@junichi11 junichi11 deleted the module-review-api.xml branch October 7, 2017 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants