Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use local .m2 cache in build by default. #2710

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

neilcsmith-net
Copy link
Member

@neilcsmith-net neilcsmith-net commented Jan 25, 2021

Always download Maven binaries by default rather than relying on local .m2 cache (issues with Jenkins builds).
Expose binaries.repos property so source repositories of binaries can be configured, including local .m2 if desired.

Passing eg. -Dbinaries.repos="file:///<HOME>/.m2/repository/ https://repo1.maven.org/maven2/"to ant still allows use of local binaries if necessary.

Always download Maven binaries by default rather than relying on local .m2 cache (issues with Jenkins builds).
Expose binaries.repos property so source repositories of binaries can be configured, including local .m2 if desired.
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane.

@neilcsmith-net neilcsmith-net added this to the 12.3 milestone Jan 26, 2021
@neilcsmith-net
Copy link
Member Author

Thanks @lkishalmi It's a simple change, but let's hope no-one / nothing is relying on the previous default. Merging - let's see if we can get a beta built!

@neilcsmith-net neilcsmith-net merged commit 6d54e71 into apache:delivery Jan 26, 2021
neilcsmith-net added a commit to neilcsmith-net/netbeans that referenced this pull request Oct 6, 2021
This was accidentally left out in apache#2710 Amongst other things, this helps with testing libraries only in local .m2 cache.
neilcsmith-net added a commit to neilcsmith-net/netbeans that referenced this pull request Jan 3, 2022
This was accidentally left out in apache#2710 Amongst other things, this helps with testing libraries only in local .m2 cache.
@neilcsmith-net neilcsmith-net deleted the ext-bin-no-m2 branch October 17, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants