Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NETBEANS-54] Module Review debugger.jpda.ui #164

Merged
merged 1 commit into from
Oct 22, 2017
Merged

[NETBEANS-54] Module Review debugger.jpda.ui #164

merged 1 commit into from
Oct 22, 2017

Conversation

junichi11
Copy link
Member

  • no external library
  • checked Rat report: add the license header to genfiles.properties and README.txt
  • skimmed through the module, did not notice additional problems

matthiasblaesing
matthiasblaesing reviewed Oct 20, 2017
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the genfiles.properties I would consider not adding a header. I added an exclude for these files. They are created and only used by the IDE.

@junichi11
Copy link
Member Author

For the genfiles.properties I would consider not adding a header.

I'll revert them. Thanks!

@junichi11 junichi11 force-pushed the module-review-debugger.jpda.ui branch from 9fe4311 to 2ce6f13 Compare October 21, 2017 10:06
@junichi11
[NETBEANS-54] Module Review debugger.jpda.ui
dbba82a 
- no external library
- checked Rat report: add the license header to README.txt
- skimmed through the module, did not notice additional problems
@junichi11 junichi11 force-pushed the module-review-debugger.jpda.ui branch from 2ce6f13 to dbba82a Compare October 22, 2017 08:04
@asfgit asfgit merged commit dbba82a into apache:master Oct 22, 2017
@junichi11 junichi11 deleted the module-review-debugger.jpda.ui branch October 22, 2017 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing left review comments

@javydreamercsw javydreamercsw javydreamercsw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@junichi11 @matthiasblaesing @javydreamercsw @asfgit