NETBEANS-87 - incorrect warning displayed #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javydreamercsw
approved these changes
Oct 20, 2017
matthiasblaesing
requested changes
Oct 20, 2017
There was a problem hiding this comment.
This looks good in general, but I have a few comments:
- please squash the commits together. Github supports updating PRs by pushing updates to the branch the PR is based on and also supports forced pushes
- Please adjust the commit message (after the squash there is only one):
- First line should hold a the jira issue in brackets and a summary
- the body should give a summary and reasoning for the changes
Thank you.
If --nogui is used on cmd line, then there's no reason to display warning about DISPLAY var not being set.
|
@matthiasblaesing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NETBEANS-87