[NETBEANS-54] Module Review uihandler

[ebarboni]

package.html was not updated by the tools

[matthiasblaesing]

The change looks good. If you squash these three commits together, the two commits
efd73df and 863393c will cancel each other out and so only the "real" change remains. This keeps the history clean.

[ebarboni]

hi, not sure how to do that, I have no squash merge is for people with write access I guess.

[emilianbold]

+1

[matthiasblaesing]

@ebarboni There are two thinks I'd like to ask you:

• Adjust your git settings to include a name and update the existing commits (see here: https://www.git-tower.com/learn/git/faq/change-author-name-email)
• Rewrite the history to squash the two commit on CLI (for GUI support you need to look into the corresponding GUI): Checkout the branch that backs this PR, run git rebase -i HEAD~3, now an editor of your choosing is started, holding one row per commit (and some help info), there you can reorder the commits, remove commits and squash them. (I failed to do that on a checkout from your repository, as git cli requires identity information, that your commits are missing, see above)

[ebarboni]

@matthiasblaesing thanks a lot for pointer on rebase. Hope its better now.

[matthiasblaesing]

@ebarboni thank you, that looks much cleaner. I have one last point: The commit message should reference the tracking bug. You had that in the PR, but that message does not get merged into the history, so I suggest, that you update the commit message to something like:

[NETBEANS-54] Module Review uihandler

package.html was not updated by the tools

You can do this by switching back to the branch backing the PR, and running git commit --amend. You can then change the commit message. This changes the commit itself and then you can do another force push.

[ebarboni]

Done

[matthiasblaesing]

Merged - thank you!