Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use InputSource to parse xml avoid encoding issue #144

Closed
wants to merge 1 commit into from
Closed

Use InputSource to parse xml avoid encoding issue #144

wants to merge 1 commit into from

Conversation

ebarboni
Copy link
Contributor

Attempt to fix build due to encoding issue in #70

@ebarboni ebarboni mentioned this pull request Oct 13, 2017
Closed
@JaroslavTulach
Copy link

JaroslavTulach commented Oct 14, 2017 •
edited
Loading

I used: curl https://github.com/apache/incubator-netbeans/pull/144.patch | git am to apply the patch. Let see if it helps.

In general XML shall contain its encoding inside of its <?xml encoding/> header, so I am surprised the change should help. But let us see.

@ebarboni ebarboni closed this Oct 16, 2017
@ebarboni ebarboni deleted the ratissue branch October 16, 2017 08:44
@jgneff jgneff mentioned this pull request Nov 4, 2022
Closed
Achal1607 added a commit to Achal1607/netbeans that referenced this pull request Feb 21, 2025
@Achal1607
Merge pull request apache#144 from Achal1607/update-jdk-downloader-li…
eee935a 
…cense

Updated OpenJDK license in JDK Downloader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebarboni @JaroslavTulach