Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-54] Module Review dlight.nativeexecution #135

Merged

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Oct 12, 2017

  • The external/exechlp-1.0.zip binary is generated by the scripts and code in tools/
  • So I'm assuming this is an Apache 2.0 license as well.
  • Added license headers to makefiles and different scripts
  • No other licensing headers required.
  • Test org.netbeans.modules.nativeexecution.api.util.ConnectionManagerTest failed in my box.

  - The external/exechlp-1.0.zip binary is generated by the scripts and code in tools/
  - So I'm assuming this is an Apache 2.0 license as well.
  - Added license headers to makefiles and different scripts
  - No other licensing headers required.
  - Test org.netbeans.modules.nativeexecution.api.util.ConnectionManagerTest failed in my box.
@vieiro
Copy link
Contributor Author

vieiro commented Oct 13, 2017

The assumption is correct: external/exchlp-1.0.zip (generated within the module) is indeed covered by the Apache 2.0 License:

@asfgit asfgit merged commit c95443b into apache:master Oct 15, 2017
@vieiro vieiro deleted the netbeans-54-module-review-dlight.nativeexecution branch October 21, 2017 18:03
Achal1607 added a commit to Achal1607/netbeans that referenced this pull request Feb 21, 2025
Bump up @vscode/debugadapter from 1.55.1 to 1.65.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants