Fix Imports should not change order of use groups unless PSR-12 order is enabled

[czukowski]

Apache NetBeans version

Apache NetBeans 19 release candidate 3

What happened

"Put in PSR-12 order" option is used to make sure use groups (types, functions, constants) are in the correct order as required by the standard. However, the order is changed even if the option is disabled when using "Fix Imports". It probably shouldn't assume any order by default.

Also, "Put in PSR-12 order" only seems to affect "Fix Imports" and not using "Source > Format".

How to reproduce

Disable 'Put in PSR-12 order' and use 'Fix imports' with the following code:

<?php
use Generator;
use Iterator;
use ArrayIterator;
use function sort;
use function next;
use function valid;
use const SORT_NUMERIC;

Expected result:

<?php
use ArrayIterator;
use Generator;
use Iterator;
use function next;
use function sort;
use function valid;
use const SORT_NUMERIC;

Actual result:

<?php

use ArrayIterator;
use Generator;
use Iterator;
use const SORT_NUMERIC;
use function next;
use function sort;
use function valid;

Did this work correctly in an earlier version?

No

Operating System

Windows 10

JDK

18.0.2.1; OpenJDK 64-Bit Server VM 18.0.2.1+1-1

Apache NetBeans packaging

Apache NetBeans binary zip

Anything else

Low priority issue.

Are you willing to submit a pull request?

No

[junichi11]

Not a bug but an enhancement. (It's a correct result, currently. It's the same behavior as before.)

[junichi11]

It probably shouldn't assume any order by default.

At least, We need default order if there are no existing uses (or if missing use kinds are added).

[czukowski]

Okay, you're right about the default order for adding use groups, but it just feels unexpected if the order of something that's already there changes suddenly. If you don't notice and fix it, then you'll have to go back and fix your commits.

I guess ideally new imports should be added in a correct order but at the same time not to make other changes to imports. But I'm not sure how achieve that in a way that wouldn't be complicated.