Merge pull request #7284 from mbien/fixed-some-code-analyzer-warnings…

…_delivery Fixed some static code analyzer warnings
apache · Apr 26, 2024 · c7b27a5 · c7b27a5
2 parents 5889acc + 8da11fc
commit c7b27a5
Show file tree

Hide file tree

Showing 24 changed files with 37 additions and 762 deletions.
diff --git a/enterprise/web.monitor/src/org/netbeans/modules/web/monitor/client/MonitorAction.java b/enterprise/web.monitor/src/org/netbeans/modules/web/monitor/client/MonitorAction.java
@@ -108,8 +108,5 @@ private static void openTransactionView() {
         tv.requestActive();        
     }
 
-    public static void log(String s) {
-	log("MonitorAction::" + s); //NOI18N
-    }
 }
 
diff --git a/...src/org/netbeans/modules/groovy/editor/completion/provider/GroovyCompletionCollector.java b/...src/org/netbeans/modules/groovy/editor/completion/provider/GroovyCompletionCollector.java
@@ -539,7 +539,7 @@ public boolean isPrefixMatch() {
 
         @Override
         public boolean isCaseSensitive() {
-            return isCaseSensitive();
+            return GroovyCompletionCollector.isCaseSensitive();
         }
     }
 

diff --git a/...csl.api/src/org/netbeans/modules/csl/editor/completion/MethodParamsTipPaintComponent.java b/...csl.api/src/org/netbeans/modules/csl/editor/completion/MethodParamsTipPaintComponent.java
@@ -39,9 +39,9 @@ public class MethodParamsTipPaintComponent extends JToolTip {
     private int descent;
     private FontMetrics fontMetrics;
 
-    private List<List<String>> params;
-    private int idx;
-    private JTextComponent component;
+    private final List<List<String>> params;
+    private final int idx;
+    private final JTextComponent component;
 
     public MethodParamsTipPaintComponent(List<List<String>> params, int idx, JTextComponent component){
         super();
@@ -123,11 +123,6 @@ protected int getWidth(String s, Font font) {
         return getFontMetrics(font).stringWidth(s);
     }
 
-    protected int getHeight(String s, Font font) {
-        if (font == null) return fontMetrics.stringWidth(s);
-        return getFontMetrics(font).stringWidth(s);
-    }
-
     public @Override void setFont(Font font) {
         super.setFont(font);
         fontMetrics = this.getFontMetrics(font);

diff --git a/ide/editor.fold.nbui/src/org/netbeans/modules/editor/fold/ui/FoldOptionsPanel.java b/ide/editor.fold.nbui/src/org/netbeans/modules/editor/fold/ui/FoldOptionsPanel.java
@@ -172,14 +172,14 @@ public void preferenceChange(PreferenceChangeEvent evt) {
                 foldedSummary.setEnabled(enabled);
                 useDefaults.setEnabled(enabled);
             } 
-            if (k == null || FoldUtilitiesImpl.PREF_CONTENT_PREVIEW.equals(FoldUtilitiesImpl.PREF_CONTENT_PREVIEW)) {
+            if (k == null || k.equals(FoldUtilitiesImpl.PREF_CONTENT_PREVIEW)) {
                 contentPreview.setSelected(currentPreferences.getBoolean(FoldUtilitiesImpl.PREF_CONTENT_PREVIEW, true));
             }
-            if (k == null || FoldUtilitiesImpl.PREF_CONTENT_SUMMARY.equals(FoldUtilitiesImpl.PREF_CONTENT_SUMMARY)) {
+            if (k == null || k.equals(FoldUtilitiesImpl.PREF_CONTENT_SUMMARY)) {
                 foldedSummary.setSelected(currentPreferences.getBoolean(FoldUtilitiesImpl.PREF_CONTENT_SUMMARY, true));
             } 
             // must not replicate defaults over current settings if unspecified key arrives.
-            if (k != null && FoldUtilitiesImpl.PREF_OVERRIDE_DEFAULTS.equals(k)) {
+            if (FoldUtilitiesImpl.PREF_OVERRIDE_DEFAULTS.equals(k)) {
                 boolean b = parentPrefs == null || !currentPreferences.getBoolean(FoldUtilitiesImpl.PREF_OVERRIDE_DEFAULTS, true);
                 if (parentPrefs != null) {
                     if (b) {