Removed a lot of compiler warnings (#5487)

Inserted diamond in constructions like this:
ArrayList<Strings> = new ArrayList();
No any interfaces was changed

apisupport/apisupport.refactoring/src/org/netbeans/modules/apisupport/refactoring/NbMoveRefactoringPlugin.java

@@ -82,7 +82,7 @@ public class NbMoveRefactoringPlugin extends AbstractRefactoringPlugin {
     private EditableManifest targetManifest;
 
     private Map packagePostfix = new HashMap();
-    ArrayList<FileObject> filesToMove = new ArrayList();    
+    ArrayList<FileObject> filesToMove = new ArrayList<>();
     HashMap<FileObject,ElementHandle> classes;
 
     /**
@@ -647,7 +647,7 @@ private String concat(String s1, String s2, String s3) {
     }  
 
    private void initClasses() {
-        classes = new HashMap();
+        classes = new HashMap<>();
         for (int i=0;i<filesToMove.size();i++) {
             final int j = i;
             try {

contrib/cordova.platforms.ios/src/org/netbeans/modules/cordova/platforms/ios/IOSDebugTransport.java

@@ -350,7 +350,7 @@ protected void sendInitCommands() throws Exception {
 
     private class Tabs {
 
-        private HashMap<String, TabDescriptor> map = new HashMap();
+        private HashMap<String, TabDescriptor> map = new HashMap<>();
         private Object monitor = new Object();
         private boolean inited = false;
 
@@ -365,7 +365,7 @@ public boolean update(NSObject r) throws Exception {
             }
             boolean wasEmpty = map.isEmpty();
             boolean connectionUrlFound = false;
-            HashMap<String, TabDescriptor> currentMap = new HashMap();
+            HashMap<String, TabDescriptor> currentMap = new HashMap<>();
             for (String s : listing.allKeys()) {
                 NSDictionary o = (NSDictionary) listing.objectForKey(s);
                 NSObject identifier = o.objectForKey("WIRPageIdentifierKey"); // NOI18N

contrib/cordova.platforms.ios/test/unit/src/org/netbeans/modules/cordova/platforms/ios/PlistTest.java

@@ -49,7 +49,7 @@ public void testListing() throws ParserConfigurationException, SAXException, IOE
 
 class Tabs {
 
-    private HashMap<String, TabDescriptor> map = new HashMap();
+    private HashMap<String, TabDescriptor> map = new HashMap<>();
 
     public void update(InputStream is) throws Exception {
         NSDictionary root = (NSDictionary) XMLPropertyListParser.parse(is);

contrib/j2ee.jboss4/src/org/netbeans/modules/j2ee/jboss4/customizer/CustomizerSupport.java

@@ -151,7 +151,7 @@ public static String buildPath(List<URL> path) {
      * @return A tokenization of the specified path into the list of URLs.
      */
     public static List<URL> tokenizePath(String path) {
-            List<URL> l = new ArrayList();
+            List<URL> l = new ArrayList<>();
             StringTokenizer tok = new StringTokenizer(path, ":;", true); // NOI18N
             char dosHack = '\0';
             char lastDelim = '\0';

contrib/j2ee.weblogic9/src/org/netbeans/modules/j2ee/weblogic9/j2ee/WLJ2eePlatformFactory.java

@@ -755,7 +755,7 @@ private void initLibrariesForWLS() {
             library.setContent(J2eeLibraryTypeProvider.VOLUME_TYPE_CLASSPATH, list);
             File j2eeDoc = InstalledFileLocator.getDefault().locate(J2EE_API_DOC, null, false);
             if (j2eeDoc != null) {
-                list = new ArrayList();
+                list = new ArrayList<>();
                 addFileToList(list, j2eeDoc);
                 library.setContent(J2eeLibraryTypeProvider.VOLUME_TYPE_JAVADOC, list);
             }

contrib/j2ee.weblogic9/src/org/netbeans/modules/j2ee/weblogic9/ui/nodes/Customizer.java

@@ -204,7 +204,7 @@ public Object getElementAt(int index) {
 
         private synchronized List getData() {
             if (data == null) {
-                data = new ArrayList();
+                data = new ArrayList<>();
                 LibraryImplementation[] libImpl = platform.getLibraries();
                 for (int i = 0; i < libImpl.length; i++) {
                     data.addAll(libImpl[i].getContent(type));

contrib/websvc.metro.model/src/org/netbeans/modules/websvc/metro/model/catalog/MetroSchemaCatalog.java

@@ -66,7 +66,7 @@ public String getSystemID(String publicId) {
 
     private synchronized Map<String, String> getLocalSchemaDefs() {
         if (localSchemaDefs == null) {
-            localSchemaDefs = new HashMap();
+            localSchemaDefs = new HashMap<>();
             localSchemaDefs.putAll(getSchemaLocations(true));
         }
         return localSchemaDefs;

contrib/websvc.wsitconf/src/org/netbeans/modules/websvc/wsitconf/wsdlmodelext/WSITModelSupport.java

@@ -677,7 +677,7 @@ public static void save(WSDLComponent c) {
     }
 
     public static synchronized void save(WSDLModel model) {
-        Set<FileObject> traversedModels = new HashSet();
+        Set<FileObject> traversedModels = new HashSet<>();
         save(model, traversedModels);
     }
 
@@ -788,7 +788,7 @@ static void moveCurrentConfig(Binding b, ConfigVersion currentCfgVersion, Config
 
         // STS
         boolean sts = ProprietarySecurityPolicyModelHelper.isSTSEnabled(b);
-        List<ServiceProviderElement> sProviderElems = new ArrayList();
+        List<ServiceProviderElement> sProviderElems = new ArrayList<>();
         String issuer = null;
         String contract = null;
         String lifetime = null;

contrib/websvc.wsitconf/test/unit/src/org/netbeans/modules/websvc/wsitconf/wsdlmodelext/ProfileTest.java

@@ -66,7 +66,7 @@ public void testSecurityProfilesLayout() throws Exception {
 
         for (ConfigVersion cfgV : ConfigVersion.values()) {
             String cfgStr = ConfigVersion.CONFIG_1_0.equals(cfgV) ? "10-" : "13-";
-            ArrayList<String> profiles = new ArrayList();
+            ArrayList<String> profiles = new ArrayList<>();
             PolicyModelHelper.setConfigVersion(b, cfgV, null);
             for (SecurityProfile sP : secProfiles) {
                 if (sP.isProfileSupported(null, b, false)) {

contrib/websvc.wsitmodelext/src/org/netbeans/modules/websvc/wsitmodelext/catalog/WSITSchemaCatalog.java

@@ -81,7 +81,7 @@ public String getSystemID(String publicId) {
 
     private synchronized Map<String, String> getLocalSchemaDefs() {
         if (localSchemaDefs == null) {
-            localSchemaDefs = new HashMap();
+            localSchemaDefs = new HashMap<>();
             localSchemaDefs.putAll(Addressing10QName.ADDRESS.getSchemaLocations(true));
             localSchemaDefs.putAll(Addressing10WsdlQName.USINGADDRESSING.getSchemaLocations(true));
             localSchemaDefs.putAll(Addressing13WsdlQName.ADDRESSING.getSchemaLocations(true));

enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/adm/VulnerabilityWorker.java

@@ -114,7 +114,7 @@ public class VulnerabilityWorker implements ErrorProvider{
     private static final String GOV_DETAIL_URL = "https://nvd.nist.gov/vuln/detail/";
 
     // @GuardedBy(self)
-    private static final HashMap<Project, CacheItem> cache = new HashMap();
+    private static final HashMap<Project, CacheItem> cache = new HashMap<>();
 
     // @GuardedBy(class)
     private static VulnerabilityWorker instance;
@@ -160,7 +160,7 @@ public List<ApplicationDependencyVulnerabilitySummary> getVulnerabilities() {
 
         public Map<String, Dependency> getDependencyMap() {
             if (dependencyMap == null) {
-                dependencyMap = new HashMap();
+                dependencyMap = new HashMap<>();
                 buildDependecyMap(dependencyResult.getRoot(), dependencyMap);
             }
             return dependencyMap;
@@ -179,7 +179,7 @@ public Set<FileObject> getProblematicFiles() {
             if (getAudit().getIsSuccess()) {
                 return Collections.EMPTY_SET;
             }
-            Set<FileObject> result = new HashSet();
+            Set<FileObject> result = new HashSet<>();
             for (ApplicationDependencyVulnerabilitySummary v: getVulnerabilities()){
                 List<Vulnerability> vulnerabilities = v.getVulnerabilities();
                 if (!vulnerabilities.isEmpty()) {
@@ -276,7 +276,7 @@ public List<Diagnostic> getDiagnosticsForFile(FileObject file) {
                 return null;
             }
 
-            List<Diagnostic> result = new ArrayList();
+            List<Diagnostic> result = new ArrayList<>();
             for (ApplicationDependencyVulnerabilitySummary v: getVulnerabilities()){
                 List<Vulnerability> vulnerabilities = v.getVulnerabilities();
                 if (!vulnerabilities.isEmpty()) {
@@ -401,7 +401,7 @@ public String findVulnerability(Project project, AuditOptions auditOptions) thro
 
     private String doFindVulnerability(Project project, String compartmentId, String knowledgeBaseId, String projectDisplayName, AuditOptions auditOptions,
             ProgressHandle progressHandle, AtomicBoolean remoteCall) throws AuditException {
-        List<ApplicationDependency> result = new ArrayList();
+        List<ApplicationDependency> result = new ArrayList<>();
 
         CacheItem cacheItem = null;
         VulnerabilityReport savedAudit = null;
@@ -504,7 +504,7 @@ private String doFindVulnerability(Project project, String compartmentId, String
                 cache.put(project, cacheItem);
             }
 
-            Set<FileObject> problematicFiles = new HashSet();
+            Set<FileObject> problematicFiles = new HashSet<>();
             problematicFiles.addAll(cacheItem.getProblematicFiles());
 
             String message;
@@ -545,7 +545,7 @@ private int convert(Dependency dependency, Map<String, Integer> gavIndex, List<A
         builder.gav(gav);
         builder.nodeId(Integer.toString(n));
 
-        List<String> childrenNodeIds = new ArrayList(dependency.getChildren().size());
+        List<String> childrenNodeIds = new ArrayList<>(dependency.getChildren().size());
         for (Dependency childDependency : dependency.getChildren()) {
             int cid = convert(childDependency, gavIndex, result);
             childrenNodeIds.add(Integer.toString(cid));
@@ -640,7 +640,7 @@ private CacheItem fetchVulnerabilityItems(Project project, ApplicationDependency
 
     @Override
     public List<? extends Diagnostic> computeErrors(Context context) {
-        List<Diagnostic> result = new ArrayList();
+        List<Diagnostic> result = new ArrayList<>();
         Collection<CacheItem> items;
 
         synchronized (cache) {

enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/devmodules/api/J2eePlatform.java

@@ -285,7 +285,7 @@ public File[] getClasspathEntries(Set<ServerLibraryDependency> libraries) {
     }
 
     private List<File> getClasspath(LibraryImplementation[] libraries) {
-        List<File> classpath = new ArrayList();
+        List<File> classpath = new ArrayList<>();
         for (int i = 0; i < libraries.length; i++) {
             List classpathList = libraries[i].getContent(J2eeLibraryTypeProvider.VOLUME_TYPE_CLASSPATH);
             for (Iterator iter = classpathList.iterator(); iter.hasNext();) {

enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/Server.java

@@ -303,7 +303,7 @@ public boolean supportsModuleType(J2eeModule.Type type) {
     private Map<String, String[]> deployConfigDescriptorMap;
 
     private final void initDeploymentConfigurationFileList(FileObject fo) {
-        deployConfigDescriptorMap = new HashMap();
+        deployConfigDescriptorMap = new HashMap<>();
         FileObject deplFNames = fo.getFileObject(LAYER_DEPLOYMENT_FILE_NAMES);
         if (deplFNames != null) {
             FileObject mTypes [] = deplFNames.getChildren();

enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerFileDistributor.java

@@ -83,7 +83,7 @@ public ServerFileDistributor(ServerInstance instance, DeploymentTarget dtarget){
     private static Map<J2eeModule.Type, List<String>> j2eeTypeMap = null;
     static synchronized List getDescriptorPath(J2eeModule module) {
         if (j2eeTypeMap == null) {
-            j2eeTypeMap = new HashMap();
+            j2eeTypeMap = new HashMap<>();
             j2eeTypeMap.put(J2eeModule.Type.EJB,
                     Arrays.asList(new String[]{J2eeModule.EJBJAR_XML, J2eeModule.EJBSERVICES_XML}));
             j2eeTypeMap.put(J2eeModule.Type.WAR,

enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistry.java

@@ -513,7 +513,7 @@ private Map<String, String> cleanInitialProperties(Map<String, String> initialPr
             return Collections.<String, String>emptyMap();
         }
 
-        Map<String,String> properties = new HashMap(initialProperties);
+        Map<String,String> properties = new HashMap<>(initialProperties);
         properties.remove(InstanceProperties.URL_ATTR);
         properties.remove(InstanceProperties.USERNAME_ATTR);
         properties.remove(InstanceProperties.PASSWORD_ATTR);
@@ -593,9 +593,9 @@ private void initConfigNamesByType() {
             if (configNamesByType != null) {
                 return;
             }
-            configNamesByType = new HashMap();
+            configNamesByType = new HashMap<>();
             for (int i = 0 ; i < ALL_TYPES.length; i++) {
-                Set<String> configNames = new HashSet();
+                Set<String> configNames = new HashSet<>();
                 for (Iterator j=servers.values().iterator(); j.hasNext();) {
                     Server s = (Server) j.next();
                     String[] paths = s.getDeploymentPlanFiles(ALL_TYPES[i]);

enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/plugins/api/ServerProgress.java

@@ -49,7 +49,7 @@
 
 public class ServerProgress implements ProgressObject {
     private Object server;
-    private List<ProgressListener> listeners = new CopyOnWriteArrayList();
+    private List<ProgressListener> listeners = new CopyOnWriteArrayList<>();
     private DeploymentStatus status;
 
     /** Creates a new instance of StartServerProgress */

enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/customizer/CustomizerSupport.java

@@ -151,7 +151,7 @@ public static String buildPath(List<URL> path) {
      * @return A tokenization of the specified path into the list of URLs.
      */
     public static List<URL> tokenizePath(String path) {
-            List<URL> l = new ArrayList();
+            List<URL> l = new ArrayList<>();
             StringTokenizer tok = new StringTokenizer(path, ":;", true); // NOI18N
             char dosHack = '\0';
             char lastDelim = '\0';

enterprise/payara.tooling/src/org/netbeans/modules/payara/tooling/data/PayaraContainer.java

@@ -81,7 +81,7 @@ public enum PayaraContainer implements Comparator<PayaraContainer> {
      * conversion.
      */
     private static final Map<String, PayaraContainer> stringValuesMap
-            = new HashMap(2 * values().length);
+            = new HashMap<>(2 * values().length);
 
     // Initialize backward String conversion Map.
     static {

enterprise/tomcat5/src/org/netbeans/modules/tomcat5/customizer/CustomizerSupport.java

@@ -151,7 +151,7 @@ public static String buildPath(List<URL> path) {
      * @return A tokenization of the specified path into the list of URLs.
      */
     public static List<URL> tokenizePath(String path) {
-            List<URL> l = new ArrayList();
+            List<URL> l = new ArrayList<>();
             StringTokenizer tok = new StringTokenizer(path, ":;", true); // NOI18N
             char dosHack = '\0';
             char lastDelim = '\0';

enterprise/tomcat5/src/org/netbeans/modules/tomcat5/util/Utils.java

@@ -78,7 +78,7 @@ public static boolean pingTomcat(int port, int timeout, String serverHeader, Str
                 if (text == null || !text.startsWith("HTTP/")) { // NOI18N
                     return false; // not an http response
                 }
-                Map<String, List<String>> headerFileds = new HashMap();
+                Map<String, List<String>> headerFileds = new HashMap<>();
                 while ((text = in.readLine()) != null && text.length() > 0) {
                     int colon = text.indexOf(":");
                     if (colon <= 0) {
@@ -88,7 +88,7 @@ public static boolean pingTomcat(int port, int timeout, String serverHeader, Str
                     String value = text.substring(colon + 1).trim();
                     List<String> list = headerFileds.get(name);
                     if (list == null) {
-                        list = new ArrayList();
+                        list = new ArrayList<>();
                         headerFileds.put(name, list);
                     }
                     list.add(value);

enterprise/web.core.syntax/test/unit/src/org/netbeans/test/web/core/syntax/TestBase2.java

@@ -74,7 +74,7 @@ protected BaseKit getEditorKit(String mimeType) {
     public final void initParserJARs() throws MalformedURLException {
         String path = System.getProperty("jsp.parser.jars");
         String[] paths = PropertyUtils.tokenizePath(path);
-        List<URL> list = new ArrayList();
+        List<URL> list = new ArrayList<>();
         for (int i = 0; i< paths.length; i++) {
             String token = paths[i];
             File f = new File(token);

enterprise/web.core/test/unit/src/org/netbeans/modules/web/core/test/TestUtil.java

@@ -175,7 +175,7 @@ public static void gc() {
         System.gc();
     }
 
-    private static final Map<FileObject,Integer> loadCount = new WeakHashMap();
+    private static final Map<FileObject,Integer> loadCount = new WeakHashMap<>();
 
     /**
      * Check how many times {@link ProjectFactory#loadProject} has been called

enterprise/web.jsf.editor/test/unit/src/org/netbeans/modules/web/jsf/editor/index/ResourcesMappingModelTest.java

@@ -37,7 +37,7 @@ public ResourcesMappingModelTest(String name) {
     @Test
     public void testParseResourceFromString() throws Exception {
         String resString = "stylesheet@test.css:;script@file.js:jsLib";
-        List<ResourcesMappingModel.Resource> resources = new ArrayList(ResourcesMappingModel.parseResourcesFromString(resString));
+        List<ResourcesMappingModel.Resource> resources = new ArrayList<>(ResourcesMappingModel.parseResourcesFromString(resString));
         assertEquals(2, resources.size());
 
         ResourcesMappingModel.Resource res1 = resources.get(0);

enterprise/web.jsf/src/org/netbeans/modules/web/jsf/wizards/ManagedBeanPanelVisual.java

@@ -341,7 +341,7 @@ public HelpCtx getHelpCtx() {
         return new HelpCtx("org.netbeans.modules.web.jsf.wizards.ManagedBeanPanelVisual");
     }
 
-    private final Set<ChangeListener> listeners = new HashSet(1);
+    private final Set<ChangeListener> listeners = new HashSet<>(1);
 
     public final void addChangeListener(ChangeListener l) {
         synchronized (listeners) {

enterprise/web.jsf/src/org/netbeans/modules/web/jsf/wizards/TemplatePanelVisual.java

@@ -37,7 +37,7 @@ public class TemplatePanelVisual extends javax.swing.JPanel implements HelpCtx.P
     private static final long serialVersionUID = 1L;
     private static final String RESOURCES_FOLDER="org/netbeans/modules/web/jsf/facelets/resources/templates/";  //NOI18N
 
-    private final Map<Integer, JRadioButton> templateButtonMapping = new HashMap();
+    private final Map<Integer, JRadioButton> templateButtonMapping = new HashMap<>();
 
     /** Creates new form TemplatePanelVisual */
     public TemplatePanelVisual() {

enterprise/web.jsf/test/unit/src/org/netbeans/modules/web/jsf/refactoring/ModificationsTest.java

@@ -81,7 +81,7 @@ public void testInputStream() throws Exception {
         File outFile = new File(getWorkDir(), "faces-modification.xml");
         FileWriter fWriter = new FileWriter(outFile);
         modifications.addDifference(fileObject, difference);
-        List<Difference> differences = new LinkedList();
+        List<Difference> differences = new LinkedList<>();
         differences.add(difference);
         modifications.commit(fileObject, differences, fWriter);
         fWriter.close();

enterprise/web.jspparser/test/unit/src/org/netbeans/modules/web/jspparser/TestUtil.java

@@ -218,7 +218,7 @@ public static void initParserJARs() throws MalformedURLException {
     public static List<URL> getJARs(String propertyName) throws MalformedURLException {
         String path = System.getProperty(propertyName);
         String[] paths = PropertyUtils.tokenizePath(path);
-        List<URL> list = new ArrayList();
+        List<URL> list = new ArrayList<>();
         for (int i = 0; i< paths.length; i++) {
             String token = paths[i];
             File f = new File(token);

enterprise/web.project/test/unit/src/org/netbeans/modules/web/project/test/TestUtil.java

@@ -152,7 +152,7 @@ public static void gc() {
         System.gc();
     }
 
-    private static final Map<FileObject,Integer> loadCount = new WeakHashMap();
+    private static final Map<FileObject,Integer> loadCount = new WeakHashMap<>();
 
     /**
      * Check how many times {@link ProjectFactory#loadProject} has been called

enterprise/websvc.rest/src/org/netbeans/modules/websvc/rest/wizard/fromdb/EjbFacadeGenerator.java

@@ -158,7 +158,7 @@ public void run(WorkingCopy workingCopy) throws Exception {
                     List<GenerationOptions> methodOptions = 
                         getAbstractFacadeMethodOptions(entityNames, 
                                 genericsTypeName, "entity"); //NOI18N
-                    List<Tree> members = new ArrayList();
+                    List<Tree> members = new ArrayList<>();
                     String entityClassVar = "entityClass";                                              //NOI18N
                     Tree classObjectTree = genUtils.createType("java.lang.Class<" + 
                             genericsTypeName + ">", classElement);     //NOI18N

ergonomics/ide.ergonomics/test/unit/src/org/netbeans/modules/ide/ergonomics/fod/ConfigurationPanelTest.java

@@ -86,15 +86,15 @@ public void testCollectExtraModulesTextsFromFeatures() throws IOException {
         assertNotNull(texts);
         assertFalse(texts.isEmpty());
 
-        List<String> expected = new ArrayList();
+        List<String> expected = new ArrayList<>();
         expected.add("Required");
         assertEquals(expected, texts);
 
         texts = configurationPanel.collectExtraModulesTextsFromFeatures(features, false);
         assertNotNull(texts);
         assertFalse(texts.isEmpty());
 
-        expected = new ArrayList();
+        expected = new ArrayList<>();
         expected.add("Recommended");
         assertEquals(expected, texts);