Skip to content

Commit

Permalink
Merge pull request #7038 from sdedic/sdedic/fix-gradle-nbls-debugging
Browse files Browse the repository at this point in the history
Debugging fixes
  • Loading branch information
neilcsmith-net authored Feb 7, 2024
2 parents 8a08acc + 80b2d73 commit 1ad003c
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions extide/gradle/netbeans-gradle-tooling/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ mainClassName = 'org.netbeans.modules.gradle.DebugTooling'

sourceCompatibility = '1.8'
[compileJava, compileTestJava]*.options*.encoding = 'UTF-8'
[compileJava, compileTestJava]*.options*.debug = true

repositories {
mavenCentral()
Expand Down
2 changes: 1 addition & 1 deletion extide/gradle/netbeans-gradle-tooling/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
</target>
<target name="compile" depends="prepare-libs">
<mkdir dir="build/classes/java/main"/>
<javac srcdir="src/main/java" destdir="build/classes/java/main" classpathref="compile.classpath" release="8" includeantruntime="false"/>
<javac srcdir="src/main/java" destdir="build/classes/java/main" classpathref="compile.classpath" release="8" includeantruntime="false" debug="true"/>
</target>

<target name="jar" depends="compile">
Expand Down
4 changes: 2 additions & 2 deletions java/java.lsp.server/vscode/src/nbcode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ export function launch(
ideArgs.push('-J-Dnetbeans.logger.console=true');
}
ideArgs.push(`-J-Dnetbeans.extra.dirs=${clusterPath}`)
if (env['netbeans.extra.options']) {
ideArgs.push(...env['netbeans.extra.options'].split(' '));
if (env['netbeans_extra_options']) {
ideArgs.push(...env['netbeans_extra_options'].split(' '));
}
ideArgs.push(...extraArgs);
if (env['netbeans_debug'] && extraArgs && extraArgs.find(s => s.includes("--list"))) {
Expand Down
2 changes: 1 addition & 1 deletion java/java.lsp.server/vscode/src/test/runTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ async function main() {
extensionTestsPath,
extensionTestsEnv: {
'ENABLE_CONSOLE_LOG' : 'true',
"netbeans.extra.options" : `-J-Dproject.limitScanRoot=${outRoot} -J-Dnetbeans.logger.console=true`
"netbeans_extra_options" : `-J-Dproject.limitScanRoot=${outRoot} -J-Dnetbeans.logger.console=true`
},
launchArgs: [
'--disable-extensions',
Expand Down

0 comments on commit 1ad003c

Please sign in to comment.