da1469x: Specify custom location of da1469x_flash_loader #2842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User may now use the mynewt value FLASH_LOADER_TARGET in bootloader target to specify the da1469x_flash_loader target location.
|
BSP is definitely not a good place to have this configured - it should be in some common package for MCU as otherwise syscfg has to be defined for each BSP separately also I am not sure if syscfg is the way to go here, I'd lean towards using env variable to overwrite flash loader target and/or .elf location |
Style check summaryNo suggestions at this time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User may now use the mynewt value FLASH_LOADER_TARGET in bootloader target
to specify the da1469x_flash_loader target location.