Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Support both Gluon 1 and 2 in the hybrid containers #19470

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Nov 4, 2020

Description

Support adding HybridBlocks implementing HybridBlock.forward interface as children to the HybridSequential and HybridConcurrent containers.

Fixes #18593

@leezu leezu requested a review from szha November 4, 2020 06:31
@mxnet-bot
Copy link

Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, edge, unix-cpu, sanity, centos-cpu, clang, windows-gpu, website, miscellaneous, unix-gpu, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 4, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 4, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 4, 2020
@leezu
Copy link
Contributor Author

leezu commented Nov 4, 2020

@mxnet-bot run ci [unix-cpu, centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, unix-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 4, 2020
@szha szha merged commit 3d1df4e into apache:master Nov 4, 2020
@leezu leezu deleted the 2020-11/gluon2-containers branch November 4, 2020 20:43
vidyaravipati pushed a commit to vidyaravipati/incubator-mxnet that referenced this pull request Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deferred computation does not work in HybridSequential
4 participants