Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x][Submodule] Upgrade to oneDNN v1.6.3 (#19153) #19161

Merged
merged 1 commit into from
Sep 18, 2020
Merged

[v1.x][Submodule] Upgrade to oneDNN v1.6.3 (#19153) #19161

merged 1 commit into from
Sep 18, 2020

Conversation

anko-intel
Copy link
Contributor

  • upgrade to oneDNN v1.6 release branch

  • oneDNN v1.6

  • fix cpp test

  • build oneDNN with c++11

  • Revert "build oneDNN with c++11"

This reverts commit 5365d83.

  • oneDNN v1.6.3

@mxnet-bot
Copy link

Hey @anko-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, unix-cpu, miscellaneous, windows-cpu, centos-gpu, windows-gpu, unix-gpu, edge, clang, sanity, centos-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@anko-intel anko-intel mentioned this pull request Sep 16, 2020
Merged
6 tasks
@anko-intel
Copy link
Contributor Author

@mxnet-bot run ci [patch, project]

@mxnet-bot
Copy link

None of the jobs entered are supported.
Jobs entered by user: [patch, project]
CI supported Jobs: [edge, windows-cpu, miscellaneous, website, clang, sanity, unix-gpu, centos-cpu, centos-gpu, unix-cpu, windows-gpu]

@anko-intel
Copy link
Contributor Author

@mxnet-bot run codecov

@mxnet-bot
Copy link

Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]

@anko-intel
Copy link
Contributor Author

@pengzhao-intel could you review and merge it?

@pengzhao-intel
Copy link
Contributor

@pengzhao-intel could you review and merge it?

Seem the CI is not passed till now. Please re-trige and I will merge after CI pass.

@anko-intel
Copy link
Contributor Author

@pengzhao-intel, I tried to re-trigger codecov, but I can't. Also it seems that messages from failed code coverage are not adequate to the change.

@anko-intel
Copy link
Contributor Author

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [miscellaneous, windows-cpu, edge, windows-gpu, website, clang, unix-cpu, centos-cpu, centos-gpu, sanity, unix-gpu]

@TaoLv @anko-intel
[v1.x][Submodule] Upgrade to oneDNN v1.6.3 (apache#19153)
9889c3a 
* upgrade to oneDNN v1.6 release branch

* oneDNN v1.6

* fix cpp test

* build oneDNN with c++11

* Revert "build oneDNN with c++11"

This reverts commit 5365d83.

* oneDNN v1.6.3
@pengzhao-intel
Copy link
Contributor

@mxnet-bot run ci [codecov]

@mxnet-bot
Copy link

None of the jobs entered are supported.
Jobs entered by user: [codecov]
CI supported Jobs: [centos-cpu, miscellaneous, windows-cpu, unix-cpu, unix-gpu, centos-gpu, website, edge, clang, sanity, windows-gpu]

pengzhao-intel
pengzhao-intel approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengzhao-intel pengzhao-intel merged commit 49ba44a into apache:v1.x Sep 18, 2020
@anko-intel anko-intel deleted the anko_oneDNNv1_6_3 branch September 18, 2020 05:21
@samskalicky samskalicky mentioned this pull request Sep 30, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pengzhao-intel pengzhao-intel pengzhao-intel approved these changes

Assignees
No one assigned
Labels
MKLDNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anko-intel @mxnet-bot @pengzhao-intel @TaoLv