Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix race condition in NaiveEngine::PushAsync #19108

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Fix race condition in NaiveEngine::PushAsync #19108

merged 2 commits into from
Sep 11, 2020

Commits on Sep 10, 2020

  1. Wait for async_fun to complete in NaiveEngine::PushAsync 

    This fixes a race condition in which NaiveEngine::PushAsync was checking if the
the async_fun had completed by the end of NaiveEngine::PushAsync. If async_fun
hadn't completed yet, NaiveEngine::PushAsync would set an internal error string
and deallocate the callback, causing segfault in async_fun once it would attempt
calling the callback.
    @leezu
    leezu committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    84ee664 View commit details
    Browse the repository at this point in the history

  2. Update naive_engine.cc

    @leezu
    leezu authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    3eb2f1f View commit details
    Browse the repository at this point in the history