-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
Hey @ptrendx , Thanks for submitting the PR
CI supported jobs: [clang, edge, centos-gpu, miscellaneous, sanity, website, windows-gpu, centos-cpu, unix-cpu, windows-cpu, unix-gpu] Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, I think it might be difficult to add test cases and it should good to merge for now (since we are in the dev mode). We can always add test cases later to cover these cases. Thus, I will approve it but feel free to express your concerns @marcoabreu .
I mean we discovered a clear case where it fails, so why not add a test? |
Currently it's triggered if we train the ELECTRA-small model in GluonNLP: https://github.com/dmlc/gluon-nlp/tree/master/scripts/pretraining, which is somehow complicated. |
Maybe @ptrendx can extract the relevant part and create a unit test out of it? |
Yes, I can and will add a test (sorry for not answering it earlier). |
I added testing of integer datatype to maximum and minimum functions - currently |
Thanks! |
@mxnet-bot run ci [centos-gpu, windows-cpu] |
Jenkins CI successfully triggered : [windows-cpu, centos-gpu] |
@marcoabreu Do you think this PR is good to go? |
Description
Fixes problem reported in #18622, where the non-templated version of
isnan
was used inside min and max functions, causing failures for integer types.