Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Fix isnan usage in RTC #18984

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Fix isnan usage in RTC #18984

merged 2 commits into from
Aug 25, 2020

Conversation

ptrendx
Copy link
Member

@ptrendx ptrendx commented Aug 22, 2020

Description

Fixes problem reported in #18622, where the non-templated version of isnan was used inside min and max functions, causing failures for integer types.

@mxnet-bot
Copy link

Hey @ptrendx , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, edge, centos-gpu, miscellaneous, sanity, website, windows-gpu, centos-cpu, unix-cpu, windows-cpu, unix-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test

Copy link
Member

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, I think it might be difficult to add test cases and it should good to merge for now (since we are in the dev mode). We can always add test cases later to cover these cases. Thus, I will approve it but feel free to express your concerns @marcoabreu .

@marcoabreu
Copy link
Contributor

I mean we discovered a clear case where it fails, so why not add a test?

@sxjscience
Copy link
Member

Currently it's triggered if we train the ELECTRA-small model in GluonNLP: https://github.com/dmlc/gluon-nlp/tree/master/scripts/pretraining, which is somehow complicated.

@marcoabreu
Copy link
Contributor

Maybe @ptrendx can extract the relevant part and create a unit test out of it?

@ptrendx
Copy link
Member Author

ptrendx commented Aug 24, 2020

Yes, I can and will add a test (sorry for not answering it earlier).

@ptrendx
Copy link
Member Author

ptrendx commented Aug 24, 2020

I added testing of integer datatype to maximum and minimum functions - currently test_np_binary_funcs by default only checks floating point types.

@marcoabreu
Copy link
Contributor

Thanks!

@ptrendx
Copy link
Member Author

ptrendx commented Aug 24, 2020

@mxnet-bot run ci [centos-gpu, windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-cpu, centos-gpu]

@ptrendx
Copy link
Member Author

ptrendx commented Aug 24, 2020

@marcoabreu Do you think this PR is good to go?

@sxjscience sxjscience merged commit 8be953f into apache:master Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants